test: do not spawn rmdir in test-statwatcher
Refs: https://github.com/nodejs/node/issues/21425
When running async-hooks/test-statwatcher
locally in a loop, the first invocation always succeeds and all others fail. I see the same thing happening in recent stress tests (https://ci.nodejs.org/view/All/job/node-stress-single-test/2230/nodes=win2016-vs2017/consoleFull).
This is related to the presence of the tmpdir. Deleting the directory manually makes the next test run pass. This change prevents tmpdir.refresh()
from spawning rmdir
, and makes the test pass.
I don't know if this will fix https://github.com/nodejs/node/issues/21425. Doesn't seem related to the older failures listed there, but might be related to the failures that are happening so often now. At least I'm hopping this will help debugging locally and produce more relevant stress test runs.
I'm not familiar with async hooks, I don't know if spawning interferes by design or is an indication of a real bug. Hence, I don't know if we should land this or keep investigating. @addaleax (by looking at file history) if you have an opinion about this it would be welcome, thanks!
Stress test: https://ci.nodejs.org/view/All/job/node-stress-single-test/2231/nodes=win2016-vs2017/consoleFull
cc @nodejs/testing
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
commit message follows commit guidelines