Skip to content

readline: add readline.promises

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/readline into master

This PR adds an experimental readline.promises, similar to the ones in the dns and fs modules. The completer() argument to the Interface class, and the question() are the primary differences from the callback based implementation.

I also took this opportunity to freshen up the readline code a bit (formatting comments, replacing var with let/const, etc.).

This is still WIP because I need to port the documentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports