Skip to content

deps: cherry-pick ARM64 Windows changes to node-gyp

Rodrigo Muino Tomonari requested to merge github/fork/jkunkee/node-gyp-arm64-patch into master

It is very important to me (and to my employer) that the Electron v6 release at the end of this month (July 2019) supports ARM64 Windows without manual patching of anything. Right now, developers have to manually patch npm with node-gyp v5 or greater.

This change cherry-picks the one node-gyp change that is needed: https://github.com/nodejs/node-gyp/pull/1739

I am hoping that the size and simplicity of this change will allow it to quickly make it to Node.js v12.

This change only affects Windows and should only affect ARM64 Windows.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports