Skip to content

worker: fix crash when SharedArrayBuffer outlives creating thread

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/worker-sharedarraybuffer-childthread into master

Use the parent thread’s ArrayBuffer::Allocator when creating a Worker instance, as that allocator is guaranteed to outlive the Worker itself.

Fixes: https://github.com/nodejs/node/issues/28777 Fixes: https://github.com/nodejs/node/issues/28773

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports