Skip to content

Revert "src: remove trace_sync_io_ from env"

Rodrigo Muino Tomonari requested to merge github/fork/ChALkeR/revert-7fa5f54e6f into master

This reverts commit 7fa5f54e.

Fixes: https://github.com/nodejs/node/issues/28913

7fa5f54e breaks the logic behind --trace-sync-io, it should be enabled only at a certain point in time, while that commit enables it from the very start, causing the issue linked above.

Or am I missing something?

Refs: https://nodejs.org/api/cli.html#cli_trace_sync_io

Prints a stack trace whenever synchronous I/O is detected after the first turn of the event loop.

Refs: https://github.com/nodejs/node/pull/22726

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports