Skip to content

benchmark swap var for let refactor in for loops

Rodrigo Muino Tomonari requested to merge github/fork/RamirezAlex/benchmark-refactor into master

In benchmark directories this changes for loops using var to let when it applies for consistency. So it finishes what started on #28867

The list of files below remain using var in the nested for loops, rest which is the majority use let now for consistency.

$ grep -l 'for (var' benchmark/*/*.js
benchmark/buffers/buffer-fill.js
benchmark/buffers/buffer-iterate.js
benchmark/buffers/buffer-swap.js
benchmark/cluster/echo.js
benchmark/es/foreach-bench.js
benchmark/events/ee-add-remove.js
benchmark/fs/read-stream-throughput.js
benchmark/misc/freelist.js
benchmark/module/module-loader.js
benchmark/streams/readable-bigread.js
benchmark/streams/readable-bigunevenread.js
benchmark/streams/readable-boundaryread.js
benchmark/streams/readable-readall.js
benchmark/streams/readable-unevenread.js
benchmark/string_decoder/string-decoder.js
benchmark/util/normalize-encoding.js
benchmark/worker/echo.js
  • make -j4 test (UNIX)
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports