Skip to content

stream: writableComplete

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/stream-writablecomplete into master

This is just a suggestion. Would like to see if there is any traction behind it.

It is quite common (at least in http and middleware) to check whether any further useful work can be performed on a writable stream. This is a bit similar to onFinished.isFinished.

We also already have it here: https://github.com/nodejs/node/blob/master/lib/internal/http2/compat.js#L304

Replaces https://github.com/nodejs/node/pull/28628

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports