Skip to content

[x] http: client destroy stream

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/http-client-destroy-stream into master

This PR tries to re-use the destroy logic from streams. One small step towards making ClientRequest more stream-like.

Based on https://github.com/nodejs/node/pull/28683. Since it's close to being merged I don't want to complicate it further.

Unlike #28683. Doesn't currently swallow errors. But will only emit one error after deestroy().

Refs: https://github.com/nodejs/node/issues/28686

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports