Skip to content

http: reset parser.incoming when server request is finished

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/redo-http-incoming into master

This resolves a memory leak for keep-alive connections and does not regress in the way that 779a05d5 did by waiting for the incoming request to be finished before releasing the parser.incoming object.

Refs: https://github.com/nodejs/node/pull/28646 Refs: https://github.com/nodejs/node/pull/29263 Fixes: https://github.com/nodejs/node/issues/9668

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports