Skip to content

buffer: don't set zero fill for zero-length buffer

Rodrigo Muino Tomonari requested to merge github/fork/trevnorris/fix-ui8-zero-fill into master

The Uint8Array constructor doesn't hit the ArrayBuffer::Allocator() when length == 0. So in these cases don't set the kNoZeroFill flag, since it won't be reset.

Add test to ensure Uint8Array's are zero-filled after creating a Buffer of length zero. This test may falsely succeed, but will not falsely fail.

Fix: https://github.com/nodejs/node/issues/2930

R=@indutny R=@Fishrock123

Merge request reports