Skip to content

child_process: remove use of stream private state

Rodrigo Muino Tomonari requested to merge github/fork/ckarande/reableListeningUnitTestCheck into master

In child_process.js L#301, the state stream._readableState.readableListening is used to determine if any paused stdio streams exist, and if so, the resume() method is used to flush it. Checking this state seems unnecessary as the resume() method has no effect on the streams subscribed with readable event. Also, all existing tests pass even after removing it.

If this is correct analysis, this PR includes change as part of the issue #445, to remove direct references to internal state of the stream implementation.

cc: @addaleax @mcollina

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports