Skip to content

url: parse() fails if the auth field contains a colon(:) or at-sign(@).

Rodrigo Muino Tomonari requested to merge github/fork/ben-page/url-parse-fix into master

The solution is to add two new fields, username and password. Additionally, url.format() is updated to prefer these new fields over the auth field. The tests and docs have been updated accordingly. This should not be breaking as the behavior of the auth field was not modified.

Here's the issues: https://github.com/joyent/node/issues/25353 https://github.com/nodejs/node/issues/1802

Merge request reports