Skip to content

inspector: update faviconUrl

Rodrigo Muino Tomonari requested to merge github/fork/dokugo/update-favicon-url into master

Seeing no icon for the remote target at chrome://inspect/#devices when debugging via Chrome DevTools with --inspect switch. GET request for the icon is returning 404 status code because of incorrect request URL: https://nodejs.org/static/favicon.ico. Changed faviconUrl at src/inspector_socket_server.cc to https://nodejs.org/static/images/favicons/favicon.ico. The reason for all this is icon files being moved in https://github.com/nodejs/nodejs.org/commit/ce04045d507be7cc2f0a0347792f22097bc7422a commit.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports