Skip to content

http: remove legacy parser

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/remove-legacy-http-parser into master

Remove the legacy http_parser implementation as a dependency and all code that uses it in favor of llhttp, given that the latter has been the default for all of Node 12 with no outstanding issues.

I think one of the ideas behind making llhttp the default for v12.x is that that means that we could drop http_parser for Node 12 LTS, reducing the time that it needs to be supported. In that case, this should probably land soon-ish. I’m personally also okay with landing this before or after Node 13 only, if people prefer that.

@nodejs/tsc @nodejs/http

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports