Skip to content

crypto: use BoringSSL-compatible flag getter

Rodrigo Muino Tomonari requested to merge github/fork/codebytere/use-boringssl-compat-flag-getter into master

This PR changes HashInit to return the md flags via EVP_MD_flags() instead of EVP_MD_meth_get_flags().

In OpenSSL 1.1.1c, which Node.js bundles at present, these functions are implemented in precisely the same way (see linked implementations above), with the primary difference being that EVP_MD_flags() is exposed by BoringSSL whereas EVP_MD_meth_get_flags() is not.

This allows Electron to reduce its patch surface while changing no behavior in Node.js.

cc @tniessen

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports