Skip to content

src: fix closing weak `HandleWrap`s on GC

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/histogram-gc-close-fix into master

In 0af62aae, this was overlooked, with it possibly leading to hard crashes.

Thanks to @bcoe for pointing me to this as the cause of the failure in https://ci.nodejs.org/job/node-test-commit-freebsd/nodes=freebsd11-x64/28455/console.

Refs: https://github.com/nodejs/node/pull/29317

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports