Skip to content

process: deprecate process._tickCallback

Rodrigo Muino Tomonari requested to merge github/fork/lholmquist/deprecate-_tickCallback into master

This comment:

// A better name for this function would be runNextTicks but // it has been exposed to the process object so we keep this legacy name // TODO(joyeecheung): either remove it or make it public

suggests that the process._tickCallback isn't the correct name for this function, but since it is exposed on the process object, it needs to stay, and that it should be removed(or made public).

This PR deprecates the process._tickCallback funciton as well as adding the more appropriately named `process.runNextTicks to the process object.

While this PR does both, deprecate and make the renamed function public, I am open to changing this to just deprecate and not add a new, possibly unneeded function to the process object.

I am also looking for some guidance on where a test for a change like this should be added

ping @joyeecheung

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports