Skip to content

esm: remove proxy for builtin exports

Rodrigo Muino Tomonari requested to merge github/fork/bmeck/manual-sync-named-exports into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This removes the proxy from builtin modules used to sync named exports. Instead, a manual call to require('module').syncESMExports() will sync all the builtin exports except default properties. The semantics need documentation updated, but wanted to open this to make sure the semantics are the expected ones and make sure test changes match expectations.

CC: @nodejs/modules

Merge request reports