Skip to content

build: replace optparse for argparse in configure.py

Hello! I saw Issue #29813 (closed) and decided to take the challenge as my first commit to Node. However while looking on what was done in PR #26725 I got confused about what is gyp_args and what that PR changed about it.

Currently, my PR fails when running gyp_args += args with error TypeError: 'Namespace' object is not iterable

Can anyone give me some help about this?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports

Loading