Skip to content

http2: set stricter default maxConcurrentStreams

Rodrigo Muino Tomonari requested to merge github/fork/zys-contrib/http2-setting-maxConcurrentStreams into master

Set the default maxConcurrentStreams to NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS(0xffffffffu) and expose it so that we can get this value from http2.getDefaultSettings().

The original NGHTTP2_INITIAL_MAX_CONCURRENT_STREAMS(2 ** 31 - 1) was deprecated according to nghttp2, so I set the default maxConcurrentStreams to NGHTTP2_DEFAULT_MAX_CONCURRENT_STREAMS(0xffffffffu) here:

https://github.com/nodejs/node/blob/88ef086e39cd055a1cdc6720981f50e4791fb90f/deps/nghttp2/lib/nghttp2_session.h#L102-L103

https://github.com/nodejs/node/blob/88ef086e39cd055a1cdc6720981f50e4791fb90f/deps/nghttp2/lib/includes/nghttp2/nghttp2.h#L699-L716

Fixes: https://github.com/nodejs/node/issues/29763 Refs: https://github.com/nghttp2/nghttp2/commit/16c46114dc724278beaa6d59462f8396f35fa4a9

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports