Skip to content

stream: call end(cb) callback after destroy

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/stream-end-cb-destroyed into master

Don't deadlock calls to end(cb) after destroy(). This only partly fixes the problem in order to minimize breakage.

This becomes relevant in the future for e.g. deprecating fileStream.close(cb) in favor of fileStream.end(cb).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports