Skip to content

http2: fix file close error condition at respondWithFd

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/http2-filehandle-error into master

Closing a FileHandle almost never fails, so it was hard to notice before that stream.emit(err) would not emit an error event due to the missing event name.

Destroying the stream with the error seems like the right thing to do in that scenario.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports