Skip to content

stream: increase MAX_HWM

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/fix-readable-max-hwm into master

MAX_HWM was added in 9208c890 where the highwatermark was changed to always increase in steps of highest power of 2 to prevent increasing hwm excessivly in tiny amounts.

Why a limit was added on the highwatermark is unclear but breaks existing usage where a larger read size is used. The invariant for read(n) is that a buffer of size n is always returned. Considering a maximum ceiling on the buffer size breaks this invariant.

This PR significantly increases the limit to make it less likely to break the previous invariant and also documents the limit.

Fixes: #29933 (closed)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports