Skip to content

build: make linter failures fail `test-doc` target

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/lintfailtest-doc into master

Linter failures in the test-doc make target were not failing the build if the subsequent doctools test passed as its exit code wasn't being preserved.

Make the lint target a dependency of test-doc so that it is outside of the node_use_openssl guard -- its own dependencies have their own guards where necessary and the targets that don't require an available node (e.g. the C++ linters) will be allowed to run.

Refs: https://github.com/nodejs/node/pull/29999#discussion_r335756298

I'd overlooked this when reviewing https://github.com/nodejs/node/pull/28199 where the regression was introduced.

cc @nodejs/build-files @danbev @sam-github

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports