Skip to content

test: expand Worker test for non-shared ArrayBuffer

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/test-worker-ab-transfer into master

This test would be broken by V8 7.9 due to the changed ArrayBuffer backing store management (the same way that V8 7.8 broke this for SharedArrayBuffers). While working on a solution, it would be good to already have this test in Node.js to avoid unnecessary accidental breakage.

Refs: https://github.com/nodejs/node-v8/issues/115

Fyi @targos @titzer

There would be two ways to approach fixing this – either we make V8 more aware of the lifetime management of ArrayBuffer::Allocators by holding a shared_ptr to them itself from the backing stores and get rid of the mechanism we use for tracking SharedArrayBuffer lifetime manually in Node.js, or we expand that mechanism to also account for non-shared ArrayBuffers. Both solutions would require a non-trivial amount of work, although they should be somewhat straightforward.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports