Skip to content

[v12.x] build: build benchmark addons like test addons

Rodrigo Muino Tomonari requested to merge github/fork/gabrielschulhof/backport-29995-to-v12.x into v12.x-staging

Build the addons for benchmarks in the same way that the addons for tests are built.

PR-URL: https://github.com/nodejs/node/pull/29995 Fixes: https://github.com/nodejs/build/issues/1961 Refs: https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896 Reviewed-By: @addaleax Reviewed-By: @trott Reviewed-By: @BethGriggs Reviewed-By: @gengjiawen

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

We need this PR along with https://github.com/nodejs/node/pull/30070 because https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896

Merge request reports