Skip to content

stream: extract Readable.from in its own file

Rodrigo Muino Tomonari requested to merge github/fork/mcollina/extract-from into master

In readable-stream, we cannot release the new version built from Node 10.17.0 because IE11 does not support generators needed for async-await to be transpiled correctly. readable-stream is all about backward compatibility, so it makes sense to still support IE11, even if we’ll likely remove support in the next major (built from Node 12).

This PR moves Readable.from into its own file, so we can replace it via a browser tag in package.json, and not ship from in the browser bundle for now.

See: https://github.com/nodejs/readable-stream/pull/420

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports