Skip to content

tools: fix Python 3 syntax error in mac_tool.py

Rodrigo Muino Tomonari requested to merge github/fork/cclauss/fix-tools-mac_tool.py into master

Discovered at https://github.com/nodejs/node/issues/30129#issuecomment-546662351 Confirmed in #30143

  File "./gyp-mac-tool", line 673
    max_value_length = len(max(filelist.items(), key=lambda (k,v):len(v))[1])
                                                            ^
SyntaxError: invalid syntax

https://portingguide.readthedocs.io/en/latest/syntax.html#tuple-unpacking-in-parameter-lists

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports