Skip to content

fs: Add noop stub for FSWatcher.prototype.start

Rodrigo Muino Tomonari requested to merge github/fork/lholmquist/fs-watcher-stub-prototype-start into master

Motivation: In a previous PR, #29905, I made this method a private method since it had no value to the user.

There was discussion, https://github.com/nodejs/node/pull/29989, that maybe it should have been a runtime deprecation first, but was ultimatley decided that for this type of method, a noop stub was a better option.

This Adds back in the method, but as a noop stub, while also keeping the real implementation private

I wasn't sure if i should add the tests back in that were removed.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports