Skip to content

src: isolate->Dispose() order consistency

Rodrigo Muino Tomonari requested to merge github/fork/codebytere/consistent-dispose into master

Removes comment from UnregisterIsolate() specifying that Isolate::Dispose() should be called after UnregisterIsolate() since that's no longer the case.

This was originally added to account for issues in V8 but now there should be no relevant tasks running during either call so their order is fungible. However, for consistency's sake, we were calling most of these in the same order (dispose and then unregister) so this also moves a straggling call from node_worker to bring it in line with all others.

cc @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports