Skip to content

buffer: improve performance caused by primordials

Rodrigo Muino Tomonari requested to merge github/fork/jizusun/code-learn-20191103 into master

This is my first try, and it's based on the code-and-learn guidances This restore some performance after introducing primordialias.

Benchmark compared with master version using the methods mentioned here

Perf Comparison 

                                                                                confidence improvement accuracy (*)    (**)   (***)
 buffers/buffer-compare-offset.js n=1000000 size=16 method='offset'                            -2.56 %       ±5.19%  ±6.93%  ±9.07%
 buffers/buffer-compare-offset.js n=1000000 size=16 method='slice'                     ***     17.14 %       ±4.95%  ±6.60%  ±8.60%
 buffers/buffer-compare-offset.js n=1000000 size=16386 method='offset'                         -1.76 %       ±4.77%  ±6.35%  ±8.26%
 buffers/buffer-compare-offset.js n=1000000 size=16386 method='slice'                  ***     21.40 %       ±6.61%  ±8.81% ±11.50%
 buffers/buffer-compare-offset.js n=1000000 size=4096 method='offset'                           1.69 %       ±5.34%  ±7.12%  ±9.28%
 buffers/buffer-compare-offset.js n=1000000 size=4096 method='slice'                   ***     20.82 %       ±5.64%  ±7.52%  ±9.84%
 buffers/buffer-compare-offset.js n=1000000 size=512 method='offset'                           -1.59 %       ±5.90%  ±7.86% ±10.26%
 buffers/buffer-compare-offset.js n=1000000 size=512 method='slice'                    ***     20.01 %       ±4.67%  ±6.22%  ±8.10%

Refs: https://github.com/nodejs/node/issues/29766 Refs: https://github.com/nodejs/code-and-learn/issues/97 Refs: https://github.com/nodejs/node/pull/29633

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports