Skip to content

src: migrate to newer V8 ArrayBuffer APIs

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/no-get-contents into master
src: migrate off ArrayBuffer::GetContents

V8 deprecates GetContents() in favour of GetBackingStore(). Update our code to reflect that. V8 also deprecates Externalize() and IsExternal(); we should be able to remove all usage of this once V8 8.0 is there.

Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34

src: drop CallbackInfo for Buffer lifetime tracking

This has been rendered unnecessary by upstream V8 changes, which now allow user-provided deleter functions out of the box.

(Sadly, that function signature mismatches our deleter function signature, so we still need a heap allocation to track our deleter data.)

Refs: https://github.com/v8/v8/commit/bba5f1f43d59cf06e6043eb94d689021cc94a4e2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports