Skip to content

test: clean up http-set-trailers

Rodrigo Muino Tomonari requested to merge github/fork/lundibundi/improve-test-http-set-trailers into master
  • remove shared state of request counting from each listener by using callbacks to report test finish. This also fixes slight race condition where one of the request could finish before the other was taken into account resulting in ECONNREFUSED due to premature server.close()
  • slightly move code for better cohesion
  • fix error comment in testHttp10 'Trailer ...' -> 'No trailer ...'
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc @nodejs/testing @nodejs/http

Merge request reports