build,win: fix node.exe resource version
As was described in https://github.com/nodejs/node/issues/2963 , the resource file was not being compiled correctly and the version information in the details of node.exe
was wrong.
Simply removing the quotes from node.rc
solves this for releases and -pre
builds, but does not work for nightlies and rcs, that require rc.exe
to receive the NODE_TAG
as a preprocessor definition.
When MSBuild invokes rc.exe
, it passes NODE_TAG
unstringified, but passes it correctly to cl.exe
. Hence, this workaround was made to apply only to the resource file.
cc @nodejs/platform-windows