Skip to content

src: clean up node_file.h

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/node-file-h into master
  • Move inline functions into an -inl.h file
  • Move override function definitions into .cc files
  • Remove using statements from header files
  • Make data fields of classes private
  • Mark classes at the end of hierarchies as final

This is also partially being done in an attempt to avoid a particular internal compiler error, see https://github.com/nodejs/node/pull/30475#issuecomment-554740850 for details.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports