Skip to content

http2: make maximum invalid frames and maximum rejected streams configurable

Rodrigo Muino Tomonari requested to merge github/fork/lundibundi/http2-invalid-frames-i30505 into master

http2: replace direct array usage with struct for js_fields_

http2: allow to configure maximum tolerated invalid frames

test: update and harden http2-reset-flood

  • use new maxSessionInvalidFrames to lower the needed frames
  • slow down requests to generate less redundant after-session-close requests

http2: make maximum tolerated rejected streams configurable

Closes: https://github.com/nodejs/node/issues/30505 This should also decrease the flakiness of test-http2-reset-flood.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Also, do we have a dedicated test for argument validation of createServer? I'm not sure where to put them.

/cc @nodejs/http2

Merge request reports