Skip to content

test: add test for options validation of createServer

Rodrigo Muino Tomonari requested to merge github/fork/zys-contrib/test-http2-createserver-options into master

test: add test for options validation of http2.createServer and http2.createSecureServer

http2: remove duplicated assertIsObject We have invoke initializeOptions(options) in Http2Server and Http2SecureServer's constructor, and we do assertIsObject(options, 'options') in initializeOptions(options), so the assertIsObject(options, 'options') in createServer and createSecureServer are duplicated. https://github.com/nodejs/node/blob/c1f0e80989cc653e5177827cf1f40785d32dc204/lib/internal/http2/core.js#L2765-L2766

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports