Skip to content

deps: backport 56a0a79 from V8 upstream

Rodrigo Muino Tomonari requested to merge github/fork/misterdjules/vee-eight-4.6-postmortem-update into vee-eight-4.6

Backport 56a0a797f210e04746f2888116365d29a4bb6afc from V8 upstream to include post-mortem metadata used by mdb_v8 to support V8 4.6.

Original commit message:

Update post-mortem metadata generation

mdb_v8, a post-mortem debugger for Node.js, now uses JSArrayBuffer's backing_store property and JSArrayBufferView's byte_offset property to get access to the content of Buffer instances in node (which are Uint8Array instances). This change adds post-mortem metadata for these two properties.

This change also fixes a typo in inobject_properties_of_constructor_function_index_offset that was added to gen-postmortem-metadata in a previous change. It should be named inobject_properties_or_constructor_function_index instead.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/1363403003

Cr-Commit-Position: refs/heads/master@{#30926 (closed)}

/cc @targos @ofrobots @nodejs/post-mortem

See related mdb_v8 change here: https://github.com/misterdjules/mdb_v8/commit/853e3377f5540ff04989b4dd58437515dc237d86.

Merge request reports