Skip to content

stream: call _final synchronously

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/stream-fix-end-finish into master
  • We don't actually have to call _final in a nextTick we just need to emit the event asynchronously. Try to call _final as soon as possible. With this change it's possible to remove some prefinish hacks where prefinish is used to get a synchronous pre _final.

This is blocking some other pending fixes.

Blocked by https://github.com/nodejs/node/pull/29656

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports