Skip to content

Windows CI job update changes

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-JBR-vcbuild-CI-master into master

The Windows CI job currently includes direct calls to cctest and test.py. Moving most of the logic back to vcbuild has been in our backlog since the change was made.

This became necessary now because I'm working on an update to the CI job that makes it work for all Node.js versions, if the vcbuild targets are there. I will open backport PRs to active branches.

The second commit fixes an issue where failures cctest make the job become yellow rather than red. Since this works with the new target, this will only apply to the new job.

Refs: https://github.com/nodejs/build/issues/1996

cc @nodejs/build @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports