Skip to content

build: remove (almost) unused macros/constants

Rodrigo Muino Tomonari requested to merge github/fork/bcoe/retire-macros into master

Macros, like CHECK, cause issues for tracking coverage because they modify the source before it's placed in V8. Upon investigation it seemed that we only used this functionality in two places: internal/vm/module.js, and internal/async_hooks.js (in comments).

Given this, it seemed to make more sense to move CHECK to JavaScript, and retire a mostly unused build step.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports