Skip to content

build,win: support building MSI with VS2019

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-JCB-msi-vs2019 into master

Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible.

cc @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports