Skip to content

src: unregister Isolate with platform before disposing

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/revert-30181 into master

I previously thought the order of these calls was no longer relevant. I was wrong.

This commit undoes the changes from 312c02d2, adds a comment explaining why I was wrong, and flips the order of the calls elsewhere for consistency, the latter having been the goal of 312c02d2.

Fixes: https://github.com/nodejs/node/issues/30846 Refs: https://github.com/nodejs/node/pull/30181

/cc @codebytere

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports