Skip to content

build,win: fix goto exit in vcbuild

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-JCD-fix-vcbuild-exit into master

In https://github.com/nodejs/node/commit/3b484edce3736cbcba26be1eec512df5282ca5bf I changed vcbuild.bat to exit with an error if cctest fails.

While in many places vcbuild.bat exits immediately with exit /b 1 if an error is found, I missed that in other places it jumps to :exit and expects it exit with error. My change broke this, and this PR should fix it.

This should land in all LTS branches.

cc @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports