Skip to content

src: explicitly allocate backing stores for v8 stat buffers

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/backing-store-clashes into master

This fixes flaky tests that crashed because the allocations ended up at positions of previously allocated ArrayBuffers that were still in the backing store table. In particular, there was a race condition window between destroying a Worker thread’s Environment and destroying its Isolate in which the underlying memory was already released but the ArrayBuffer was still existent, meaning that new memory could be allocated at the address of the previous ArrayBuffer.

Refs: https://github.com/nodejs/node/pull/30782

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports