Skip to content

stream: avoid unhandled exception when destroy w/ callback.

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/stream-destroy-error-cb into master

Providing a callback to destroy means that the error should be handled through that callback and thus an unhandled exception error should not be necessary.

Some minor preparation towards possibly making the destroy(err, cb) signature public.

With "better" ergonomics I'm hoping users that usually skip adding an 'error' listeners before destroy() no longer end up with unhandled exceptions in edge cases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports