Skip to content

zlib: allow writes after readable 'end' to finish

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/zlib-finish-writes into master

Call the callback for writes that occur after the stream is closed. This also requires changes to the code to not call .destroy() on the stream in .on('end'), and to ignore chunks written afterwards.

Previously, these writes would just queue up silently, as their _write() callback would never have been called.

/cc @lpinca

Fixes: https://github.com/nodejs/node/issues/30976

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports