Skip to content

wasi: fix serdes bugs from snapshot1 migration

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/wasi-serdes into master

During the migration to WASI snapshot1, a field was removed from the subscription type. The field was removed from the code, but the bounds checking logic was not updated. This commit updates that check.

Similarly, __wasi_linkcount_t changed from a uint32_t to a uint64_t. However, the bounds checks were missed, and the code was still writing uint32_t's (to the new correct offset) instead of uint64_t's. This commit updates that logic as well.

Refs: https://github.com/nodejs/node/pull/30980

(I've also opened https://github.com/cjihrig/uvwasi/issues/69 to come up with a plan to make this process a bit smoother moving forward.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports