Skip to content

[v12 backport] lib: no need to strip BOM or shebang for scripts

Rodrigo Muino Tomonari requested to merge github/fork/aduh95/backport-27768-to-erbium into v12.x-staging

Node.js v12's V8 version has been bumped from 7.4 straight to 7.8 and missed 702331be (which was introduced with 7.5 upgrade). EDIT: I get this part wrong... As of V8 7.4, V8 implements the Hashbang Grammar proposal by default, so 702331be removed custom code that handled hashbang for scripts. As far as I can see, it has not been backported to v12 yet.

I'm also backporting #27768 to ease the conflict resolution.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports