Skip to content

src: remove preview for heap dump utilities

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/heap-snapshot-no-preview into master

At least createHeapSnapshotStream() and triggerHeapSnapshot() do have side effects, and more importantly, they should not be run transparently. Without this, typing e.g. v8.getHeapSnapshot() into the REPL will result in a crash or infinite loop while the REPL evaluates the expression for a preview.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports